RFR: 8232948: javac -h should mangle the overload argument signature

Jonathan Gibbons jjg at openjdk.java.net
Mon Jun 7 16:01:17 UTC 2021


On Thu, 3 Jun 2021 20:01:12 GMT, Joel Borggrén-Franck <jfranck at openjdk.org> wrote:

> When overloaded methods are disambiguated the appended argument signature
> should be mangled according to the spec.

Changes requested by jjg (Reviewer).

test/langtools/tools/javac/nativeHeaders/EncodeInnerClassNameTest.java line 52:

> 50:         }
> 51:     }
> 52:     """;

Suggest indenting the lines of the text block

test/langtools/tools/javac/nativeHeaders/EncodeInnerClassNameTest.java line 109:

> 107:         if (!res.equals(expected)) {
> 108:             System.err.println("Result:\n" + res);
> 109:             System.err.println("\nExpected:\n" + expected);

You probably need to take line endings into account, for Windows.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4345


More information about the compiler-dev mailing list