RFR: 8266082: AssertionError in Annotate.fromAnnotations with -Xdoclint [v2]

[Vicente Romero]

On Tue, 15 Jun 2021 11:38:14 GMT, Joel Borggrén-Franck <jfranck at openjdk.org> wrote:

>> Javac crashes in Annotate when a javadoc reference contains an annotated type, since attribType expects type annotations to have been attributed.
>> 
>> This proposed fix checks references at parse time to disallow annotated types instead of crashing later on.
>> 
>> Since the exact type of error is known I opted for a new error message to make it easier for the developer to see what is wrong.
>> 
>> Since this affects javac at least as far back as jdk 11 and we are past RDP1 I targeted this for 18.
>
> Joel Borggrén-Franck has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8266082: Use nodynamiccopyright and add test cases

test/langtools/tools/doclint/CrashInAnnotateTest.out line 4:

> 2: CrashInAnnotateTest.java:14:5: compiler.err.proc.messager: annotations not allowed
> 3: CrashInAnnotateTest.java:16:10: compiler.warn.proc.messager: no comment
> 4: CrashInAnnotateTest.java:19:5: compiler.err.proc.messager: syntax error in reference

I think that this errors are because the annotation is fully qualified

-------------

PR: https://git.openjdk.java.net/jdk/pull/4483