RFR: 8266082: AssertionError in Annotate.fromAnnotations with -Xdoclint [v3]

[Joel Borggrén-Franck]

> Javac crashes in Annotate when a javadoc reference contains an annotated type, since attribType expects type annotations to have been attributed.
> 
> This proposed fix checks references at parse time to disallow annotated types instead of crashing later on.
> 
> Since the exact type of error is known I opted for a new error message to make it easier for the developer to see what is wrong.
> 
> Since this affects javac at least as far back as jdk 11 and we are past RDP1 I targeted this for 18.

Joel Borggrén-Franck has updated the pull request incrementally with one additional commit since the last revision:

  8266082: Review feedback

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/4483/files
  - new: https://git.openjdk.java.net/jdk/pull/4483/files/8c387d12..b7953cff

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=4483&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=4483&range=01-02

  Stats: 13 lines in 2 files changed: 3 ins; 0 del; 10 mod
  Patch: https://git.openjdk.java.net/jdk/pull/4483.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/4483/head:pull/4483

PR: https://git.openjdk.java.net/jdk/pull/4483