RFR: 8266082: AssertionError in Annotate.fromAnnotations with -Xdoclint [v4]

Vicente Romero vromero at openjdk.java.net
Wed Jun 16 15:21:39 UTC 2021


On Wed, 16 Jun 2021 07:30:09 GMT, Joel Borggrén-Franck <jfranck at openjdk.org> wrote:

>> Javac crashes in Annotate when a javadoc reference contains an annotated type, since attribType expects type annotations to have been attributed.
>> 
>> This proposed fix checks references at parse time to disallow annotated types instead of crashing later on.
>> 
>> Since the exact type of error is known I opted for a new error message to make it easier for the developer to see what is wrong.
>> 
>> Since this affects javac at least as far back as jdk 11 and we are past RDP1 I targeted this for 18.
>
> Joel Borggrén-Franck has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8266082: Test more cases

looks good, thanks

-------------

Marked as reviewed by vromero (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/4483


More information about the compiler-dev mailing list