RFR: 8198317: Enhance JavacTool.getTask for flexibility

Jonathan Gibbons jjg at openjdk.java.net
Tue Mar 9 05:26:07 UTC 2021

On Mon, 8 Mar 2021 11:21:38 GMT, Jan Lahoda <jlahoda at openjdk.org> wrote:

> This is a clone of https://github.com/openjdk/jdk/pull/1896, which got closed by Skara.
> @lgxbslgx, please let me know if you would prefer to resubmit the PR yourself.

Changes requested by jjg (Reviewer).

test/langtools/tools/javac/api/8198317/T8198317.java line 54:

> 52: import static toolbox.ToolBox.lineSeparator;
> 53: 
> 54: public class T8198317 extends TestRunner{

These days, it is considered bad form to base a test name on a bug number. It's better to come up with a meaningful name for the test.  That probably applies to the enclosing directory as well.


PR: https://git.openjdk.java.net/jdk/pull/2871

More information about the compiler-dev mailing list