RFR: 8263514: Minor issue in JavacFileManager.SortFiles.REVERSE

Vicente Romero vromero at openjdk.java.net
Mon Mar 15 17:25:08 UTC 2021

On Fri, 12 Mar 2021 13:52:51 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

> SonarCloud reports the problem in  JavacFileManager.SortFiles.REVERSE definition:
>  Neither "Math.abs" nor negation should be used on numbers that could be "MIN_VALUE"
>         REVERSE {
>             @Override
>             public int compare(Path f1, Path f2) {
>                 return -f1.getFileName().compareTo(f2.getFileName());
>             }
>         }
> Since `compareTo` can technically return `MIN_VALUE`, we cannot simply negate it. Luckily, we can just swap the `f1` and `f2` comparison order to achieve the same effect without exposing us to this corner case.

looks good


Marked as reviewed by vromero (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/2970

More information about the compiler-dev mailing list