Integrated: 8263514: Minor issue in JavacFileManager.SortFiles.REVERSE

Aleksey Shipilev shade at
Mon Mar 15 17:41:11 UTC 2021

On Fri, 12 Mar 2021 13:52:51 GMT, Aleksey Shipilev <shade at> wrote:

> SonarCloud reports the problem in  JavacFileManager.SortFiles.REVERSE definition:
>  Neither "Math.abs" nor negation should be used on numbers that could be "MIN_VALUE"
>         REVERSE {
>             @Override
>             public int compare(Path f1, Path f2) {
>                 return -f1.getFileName().compareTo(f2.getFileName());
>             }
>         }
> Since `compareTo` can technically return `MIN_VALUE`, we cannot simply negate it. Luckily, we can just swap the `f1` and `f2` comparison order to achieve the same effect without exposing us to this corner case.

This pull request has now been integrated.

Changeset: 5ab52448
Author:    Aleksey Shipilev <shade at>
Stats:     1 line in 1 file changed: 0 ins; 0 del; 1 mod

8263514: Minor issue in JavacFileManager.SortFiles.REVERSE

Reviewed-by: vromero



More information about the compiler-dev mailing list