RFR: 8263995: Incorrect double-checked locking in Types.arraySuperType() [v2]

Mon Mar 22 21:00:47 UTC 2021

On Mon, 22 Mar 2021 19:06:00 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> In Types.arraySuperType(), SonarCloud reports:
>>  Remove this dangerous instance of double-checked locking.
>> 
>> Indeed, the `arraySuperType` is not `volatile`, while `IntersectionClassType` has non-`final` fields (both in itself and in superclasses). This is an incorrect DCL.
>
> Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Drop synchronization and volatileness

Looks good

-------------

Marked as reviewed by mcimadamore (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/3129