RFR: 8244146: javac changes for JEP 306 [v4]

[Joe Darcy]

On Wed, 5 May 2021 06:29:50 GMT, Srikanth Adayapalam <sadayapalam at openjdk.org> wrote:

>> Joe Darcy has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Respond to review feedback.
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Check.java line 1326:
> 
>> 1324:     private void warnOnExplicitStrictfp(DiagnosticPosition pos, JCTree tree) {
>> 1325:         DiagnosticPosition prevLintPos = deferredLintHandler.setPos(tree.pos());
>> 1326:         try {
> 
> Do we need tree passed as a parameter at all ? Why can't we use just pos instead of tree.pos() Looking at the 3 call sites of checkFlags it seems guaranteed that pos is same as tree.pos() ?

Yes; tree argument is unnecessary, removed in a subsequent push.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3831