RFR: 8241187: ToolBox::grep should allow for negative filtering [v4]

Guoxiong Li gli at openjdk.java.net
Tue May 11 05:34:22 UTC 2021


> Hi all,
> 
> This patch adds two methods in `ToolBox` to do the negative filtering. Although the label `noreg-self` was added, I write a test for this enhancement to verify the code. And the method name `grepNotMatch` may need to be improved. Any idea is appreciated.
>  
> Thank you for taking the time to review.
> 
> Best Regards.

Guoxiong Li has updated the pull request incrementally with one additional commit since the last revision:

  Revise comments. Adjust parameter. Clean code.

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/1934/files
  - new: https://git.openjdk.java.net/jdk/pull/1934/files/f1ae6684..9058e6f9

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=1934&range=03
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=1934&range=02-03

  Stats: 34 lines in 2 files changed: 4 ins; 10 del; 20 mod
  Patch: https://git.openjdk.java.net/jdk/pull/1934.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/1934/head:pull/1934

PR: https://git.openjdk.java.net/jdk/pull/1934


More information about the compiler-dev mailing list