RFR: 8241187: ToolBox::grep should allow for negative filtering [v4]

[Guoxiong Li]

On Tue, 11 May 2021 12:34:43 GMT, Florent Guillaume <github.com+592810+efge at openjdk.org> wrote:

>> test/langtools/tools/lib/toolbox/ToolBox.java line 210:
>> 
>>> 208:     public List<String> grep(Pattern pattern, List<String> lines, boolean match) {
>>> 209:         return lines.stream()
>>> 210:                 .filter(s -> match ? pattern.matcher(s).find() : !pattern.matcher(s).find())
>> 
>> `s -> pattern.matcher(s).find() ^ !match` would avoid repeating the expression
>
> Or probably even simpler `s -> pattern.matcher(s).find() == match`

Good idea. Fixed.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1934