RFR: 8226216: parameter modifiers are not visible to javac plugins across compilation boundaries [v3]

[Guoxiong Li]

On Tue, 11 May 2021 10:48:51 GMT, Jan Lahoda <jlahoda at openjdk.org> wrote:

>> Guoxiong Li has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
>> 
>>  - Use meaningful class name and update copyright
>>  - Merge branch 'master' into JDK-8226216
>>  - Modify legal header. Fix typo.
>>  - 8226216: parameter modifiers are not visible to javac plugins across compilation boundaries
>
> test/langtools/tools/javac/classreader/ParameterModifiersAcrossCompilationBoundaries.java line 87:
> 
>> 85:                                         TypeElement typeElement = elements.getTypeElement("B");
>> 86:                                         for (Element m : typeElement.getEnclosedElements()) {
>> 87:                                             if (m instanceof ExecutableElement) {
> 
> Since this is a test, not so huge deal, but it might be better to do filtering using `ElementFilter.methodsIn` - it is easier to use than `Element.getKind()`, and safer than `instanceof` (which is not very much safe for `Element`s).

Thanks for you suggestion. I revised the code by using `ElementFilter.methodsIn`.

> test/langtools/tools/javac/classreader/ParameterModifiersAcrossCompilationBoundaries.java line 148:
> 
>> 146:                 .options("--processor-module-path", "plugin", "-Xplugin:P",
>> 147:                          "-parameters", "-classpath", "test")
>> 148:                 .files("test/B.java")
> 
> Does the test really test the ClassReader behavior? It seems B is always originating in the source, and the test is looking at a parameter from the B file? Maybe the idea was `test/A.java` would be used here?

It should be `test/A.java`. Fixed.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1890