Integrated: 8226216: parameter modifiers are not visible to javac plugins across compilation boundaries

Guoxiong Li gli at openjdk.java.net
Wed May 12 14:36:05 UTC 2021


On Thu, 24 Dec 2020 16:02:19 GMT, Guoxiong Li <gli at openjdk.org> wrote:

> Hi all,
> 
> javac fails to read modifiers from the MethodParameters attribute in class files, which prevents plugins from accessing those modifiers across compilation boundaries. Because `com.sun.tools.javac.jvm.ClassReader` doesn't read and store the access flags(modifiers) from MethodParameters attribute.
> 
> This patch fixes it and adds a corresponding test case. All the existing tests of javac passed locally.
> 
> Thank you for taking the time to review.
> 
> Best Regards.

This pull request has now been integrated.

Changeset: accbfeaf
Author:    Guoxiong Li <gli at openjdk.org>
Committer: Jan Lahoda <jlahoda at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/accbfeaf22ea5374292a657ddabb67b22eada6bc
Stats:     168 lines in 2 files changed: 167 ins; 0 del; 1 mod

8226216: parameter modifiers are not visible to javac plugins across compilation boundaries

Reviewed-by: jlahoda

-------------

PR: https://git.openjdk.java.net/jdk/pull/1890


More information about the compiler-dev mailing list