RFR: 8267570: The comment of the class JavacParser is not appropriate [v2]

Guoxiong Li gli at openjdk.java.net
Sun May 23 08:19:30 UTC 2021


On Sat, 22 May 2021 16:40:52 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

>> Guoxiong Li has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Revise comment
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/parser/JavacParser.java line 68:
> 
>> 66:  * The parser maps a token sequence into an abstract syntax tree.
>> 67:  * The current javac parser is a hand-written recursive-descent parser.
>> 68:  * It implements the grammar described in the Java Language Specification.
> 
> In general, temporal words (like "current") should be avoided as a matter of style.
> 
> I suggest:
> 
> The parser is a hand-written recursive-descent parser that
> implements the grammar described in the Java Language Specification.

Fixed.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4153


More information about the compiler-dev mailing list