RFR: 8267578: Remove unnecessary preview checks

[Jan Lahoda]

On Sun, 23 May 2021 11:04:56 GMT, Guoxiong Li <gli at openjdk.org> wrote:

> Hi all,
> 
> The following preview checks are unnecessary because they are standard features now.
> 
> Attr.java
> 
>         allowReifiableTypesInInstanceof =
>                 Feature.REIFIABLE_TYPES_INSTANCEOF.allowedInSource(source) &&
>                 (!preview.isPreview(Feature.REIFIABLE_TYPES_INSTANCEOF) || preview.isEnabled());
> 
> 
> JavacParser.java
> 
>         this.allowYieldStatement = (!preview.isPreview(Feature.SWITCH_EXPRESSION) || preview.isEnabled()) &&
>                 Feature.SWITCH_EXPRESSION.allowedInSource(source);
> 
> 
> Resolve.java
> 
>         allowYieldStatement = (!preview.isPreview(Feature.SWITCH_EXPRESSION) || preview.isEnabled()) &&
>                 Feature.SWITCH_EXPRESSION.allowedInSource(source);
> 
> 
> It is good to remove them.
> Thanks for review.
> 
> Best Regards,
> -- Guoxiong

Looks good to me.

@JimLaskey - please note that javac does not support preview features from previous versions (as per JEP 12). So once a feature is made final, it is safe to remove the preview checks, AFAIK, it just was not done for these few cases.

-------------

Marked as reviewed by jlahoda (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/4157