RFR: 8274544: Langtools command's usage were garbled on Japanese Windows [v5]
Ichiroh Takiguchi
itakiguchi at openjdk.java.net
Thu Nov 4 16:58:14 UTC 2021
On Wed, 3 Nov 2021 18:41:19 GMT, Naoto Sato <naoto at openjdk.org> wrote:
>> Ichiroh Takiguchi has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits:
>>
>> - 8274544: Langtools command's usage were garbled on Japanese Windows
>> - 8274544: Langtools command's usage were garbled on Japanese Windows
>> - 8274544: Langtools command's usage were garbled on Japanese Windows
>> - 8274544: Langtools command's usage were garbled on Japanese Windows
>> - Langtools command's usage were grabled on Japanese Windows
>
> Firstly, please do NOT rebase your fix, as it will clobber the review history. Use merge instead.
> As to the fix, I am not sure consolidating the code into Log.java would be OK as it would introduce module dependency.
@naotoj
I'm sorry about my bad operation.
@jonathan-gibbons
I appreciate if you give me some suggestions.
-------------
PR: https://git.openjdk.java.net/jdk/pull/5771
More information about the compiler-dev
mailing list