RFR: JDK-8276650: GenGraphs does not produce deterministic output

Mandy Chung mchung at openjdk.java.net
Thu Nov 4 22:20:11 UTC 2021


On Thu, 4 Nov 2021 21:46:21 GMT, Anthony Vanelverdinghe <duke at openjdk.java.net> wrote:

>> The dot graph should print the edges in alphatical order.   A simple fix to sort the edges before printing them.
>
> src/jdk.jdeps/share/classes/com/sun/tools/jdeps/ModuleDotGraph.java line 336:
> 
>> 334:         private final String name;
>> 335:         private final Graph<String> graph;
>> 336:         private final TreeSet<ModuleDescriptor> descriptors = new TreeSet<>();
> 
> This change is unnecessary, isn't it?

This will make it clear that this is sorted.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6266


More information about the compiler-dev mailing list