RFR: 8276764: Enable deterministic file content ordering for Jar and Jmod

Mandy Chung mchung at openjdk.java.net
Thu Nov 18 23:52:42 UTC 2021


On Mon, 15 Nov 2021 18:47:34 GMT, Andrew Leonard <aleonard at openjdk.org> wrote:

> Both jar and jmod utilise java.io file operations whose methods define no ordering of the return file lists, and in fact rely on OS query file ordering, which can differ by underlying OS architecture.
> This PR adds sort processing to the creation of such jar's and jmod's to enable a deterministic content ordering.
> 
> Signed-off-by: Andrew Leonard <anleonar at redhat.com>

src/jdk.jartool/share/classes/sun/tools/jar/Main.java line 130:

> 128: 
> 129:     // There's also a files array per version
> 130:     // Use a LinkedHashMap to keep original insertion ordering

Suggestion:

    // base version is the first entry and then follow with the version given
    // from the --release option in the command-line order.
    // The value of each entry is the files given in the command-line order.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6395


More information about the compiler-dev mailing list