RFR: 8276764: Enable deterministic file content ordering for Jar and Jmod [v3]
Lance Andersen
lancea at openjdk.java.net
Fri Nov 19 19:13:11 UTC 2021
On Fri, 19 Nov 2021 10:10:33 GMT, Andrew Leonard <aleonard at openjdk.org> wrote:
>> Both jar and jmod utilise java.io file operations whose methods define no ordering of the return file lists, and in fact rely on OS query file ordering, which can differ by underlying OS architecture.
>> This PR adds sort processing to the creation of such jar's and jmod's to enable a deterministic content ordering.
>>
>> Signed-off-by: Andrew Leonard <anleonar at redhat.com>
>
> Andrew Leonard has updated the pull request incrementally with one additional commit since the last revision:
>
> 8276764: Enable deterministic file content ordering for Jar and Jmod
>
> Signed-off-by: Andrew Leonard <anleonar at redhat.com>
src/jdk.jartool/share/classes/sun/tools/jar/Main.java line 812:
> 810: if (uflag) {
> 811: entryMap.put(name, e);
> 812: }
Thank you for cleaning up the if missing braces in this method. Looks much better :-)
-------------
PR: https://git.openjdk.java.net/jdk/pull/6395
More information about the compiler-dev
mailing list