RFR: 8276764: Enable deterministic file content ordering for Jar and Jmod [v3]

Andrew Leonard aleonard at openjdk.java.net
Fri Nov 19 20:15:57 UTC 2021


On Fri, 19 Nov 2021 17:27:45 GMT, Mandy Chung <mchung at openjdk.org> wrote:

>> Andrew Leonard has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8276764: Enable deterministic file content ordering for Jar and Jmod
>>   
>>   Signed-off-by: Andrew Leonard <anleonar at redhat.com>
>
> The source change looks good.   I have a couple comments for the tests.

@mlchung Added -C and --release to tests, looks more complete now, thanks

> test/jdk/tools/jar/ContentOrder.java line 55:
> 
>> 53: import jdk.test.lib.util.FileUtils;
>> 54: 
>> 55: public class ContentOrder {
> 
> It'd be useful to include the test cases to verify the `--release` option with the specified files and directories as well.

added

-------------

PR: https://git.openjdk.java.net/jdk/pull/6395


More information about the compiler-dev mailing list