RFR: 8224922: Access JavaFileObject from Element(s) [v16]
Joe Darcy
darcy at openjdk.java.net
Sun Nov 21 20:46:47 UTC 2021
On Thu, 18 Nov 2021 19:28:37 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:
>> Joe Darcy has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - Merge pull request #7 from lahodaj/JDK-8224922-5
>>
>> Fixing a test on Windows.
>> - Attempting to fix a Windows test.
>
> src/java.compiler/share/classes/javax/lang/model/element/package-info.java line 39:
>
>> 37: * anonymous classes.
>> 38: *
>> 39: * <p><a id="accurate_model">When used in the context of annotation processing, an accurate
>
> It would be more correct to just put the id on the `<p>` tag and drop the `<a>`.
Fixed.
> src/java.compiler/share/classes/javax/lang/model/util/Elements.java line 798:
>
>> 796: * the creation of source or class files in that package. An
>> 797: * {@linkplain PackageElement#isUnnamed unnamed package} will have
>> 798: * a null file since it cannot be declared in a compilation unit.
>
> `{@code }` around null ??
I'll fix these before pushing and do a follow-up pass over the API for consistent "null" vs "{@code null}" treatment.
-------------
PR: https://git.openjdk.java.net/jdk/pull/5038
More information about the compiler-dev
mailing list