RFR: 8276764: Enable deterministic file content ordering for Jar and Jmod [v6]

Andrew Leonard aleonard at openjdk.java.net
Tue Nov 23 10:04:54 UTC 2021


On Mon, 22 Nov 2021 14:57:01 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> Andrew Leonard has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8276764: Enable deterministic file content ordering for Jar and Jmod
>>   
>>   Signed-off-by: Andrew Leonard <anleonar at redhat.com>
>
> src/jdk.jlink/share/classes/jdk/tools/jmod/JmodTask.java line 772:
> 
>> 770:             // Keep a sorted set of files to be processed, so that the jmod
>> 771:             // content is reproducible as Files.walkFileTree order is not defined
>> 772:             SortedMap<String, Path> filesToProcess  = new TreeMap<String, Path>();
> 
> Nit: there seems to be two whitespaces (instead of one) before the `=` sign on this line.

thanks, fixed

-------------

PR: https://git.openjdk.java.net/jdk/pull/6395


More information about the compiler-dev mailing list