RFR: 8272234: Pass originating elements from Filer to JavaFileManager [v5]

[Jan Lahoda]

On Tue, 23 Nov 2021 05:33:53 GMT, Joe Darcy <darcy at openjdk.org> wrote:

>> Jan Lahoda has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 25 commits:
>> 
>>  - Test cleanup.
>>  - Merge branch 'ap-keep-originating-elements' into ap-keep-originating-elements-forwarding-tweak
>>  - Cleanup
>>  - Merge branch 'master' into ap-keep-originating-elements
>>  - Fixing test (need to exclude a private method from the test).
>>  - Fixing typo, as per review comments.
>>  - Fixing javadoc.
>>  - Cleanup.
>>  - Attempting to improve compatibility with existing subclasses of ForwardingJavaFileManager
>>  - Javadoc improvements.
>>  - ... and 15 more: https://git.openjdk.java.net/jdk/compare/ca31ed53...da4781a9
>
> src/java.compiler/share/classes/javax/tools/JavaFileManager.java line 381:
> 
>> 379:                                         String className,
>> 380:                                         Kind kind,
>> 381:                                         FileObject... originatingFiles)
> 
> Perhaps explicitly state that null originatingFile or empty originatingFiles are no-ops.

Thanks - how about the following?
https://github.com/openjdk/jdk/pull/5076/commits/7c11f10d9c2bce6a5841fcfc4580edc12692dde5

-------------

PR: https://git.openjdk.java.net/jdk/pull/5076