RFR: JDK-8276674 : Malformed Javadoc inline tags in JDK source in java/util/stream

Pavel Rappo prappo at openjdk.java.net
Thu Nov 25 00:36:09 UTC 2021


On Thu, 18 Nov 2021 03:22:50 GMT, Tim Prinzing <duke at openjdk.java.net> wrote:

> JDK-8276674 : Malformed Javadoc inline tags in JDK source in java/util/stream

Looks good.

src/jdk.compiler/share/classes/com/sun/tools/javac/util/RawDiagnosticFormatter.java line 63:

> 61:      * Helper class to generate stable positions for AST nodes occurring in diagnostic arguments.
> 62:      * If the AST node appears in the same line number as the main diagnostic, the line is information is omitted.
> 63:      * Otherwise both line and column information is included, using the format {@code line:col}".

Not a showstopper by any means. But while you are at it, maybe you could also fix this?

Suggestion:

     * If the AST node appears in the same line number as the main diagnostic, the line information is omitted.
     * Otherwise both line and column information is included, using the format {@code line:col}.

-------------

Marked as reviewed by prappo (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/6443


More information about the compiler-dev mailing list