RFR: 8276766: Enable jar and jmod to produce deterministic timestamped content [v4]

[Andrew Leonard]

On Wed, 24 Nov 2021 16:43:10 GMT, Lance Andersen <lancea at openjdk.org> wrote:

>> Andrew Leonard has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits:
>> 
>>  - 8276766: Enable jar and jmod to produce deterministic timestamped content
>>    
>>    Signed-off-by: Andrew Leonard <anleonar at redhat.com>
>>  - 8276766: Enable jar and jmod to produce deterministic timestamped content
>>    
>>    Signed-off-by: Andrew Leonard <anleonar at redhat.com>
>>  - 8276766: Enable jar and jmod to produce deterministic timestamped content
>>    
>>    Signed-off-by: Andrew Leonard <anleonar at redhat.com>
>>  - 8276766: Enable jar and jmod to produce deterministic timestamped content
>>    
>>    Signed-off-by: Andrew Leonard <anleonar at redhat.com>
>>  - 8276766: Enable jar and jmod to produce deterministic timestamped content
>>    
>>    Signed-off-by: Andrew Leonard <anleonar at redhat.com>
>
> test/jdk/tools/jar/JarEntryTime.java line 129:
> 
>> 127:         // Make a jar file from that directory structure with
>> 128:         // --source-date set to epoch seconds 1647302400 (15/03/2022)
>> 129:         long sourceDate = 1647302400L;
> 
> Please consider  adding a few before Epoch test values.

@LanceAndersen can you clarify your meaning here please? Are you referring to negative sourceDate? I put in the CSR that it was seconds "since" epoch akin to SOURCE_DATE_EPOCH, which as far as I can tell does not support negative values, as some time implementations won't support that. 
But this does imply I should add some -ve validation checks.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6481