RFR: JDK-8274744: TestSnippetTag test fails after recent integration

Pavel Rappo prappo at openjdk.java.net
Tue Oct 5 10:52:07 UTC 2021


On Mon, 4 Oct 2021 21:19:07 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

> Please review the update to `TestSnippetTag.java`, to update the "expected error"  lines and caret positions, due to the improvements in JDK-8273244.

Looks good. 

While in many cases diagnostics became more helpful, in the "unexpected content" case (missing newline after the colon) it is now more confusing. This is because the caret points to the colon and not to the unexpected character which follows the colon. We will have to improve that later.

-------------

Marked as reviewed by prappo (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/5812


More information about the compiler-dev mailing list