RFR: 8274244: ReportOnImportedModuleAnnotation.java fails on rerun [v2]

Jonathan Gibbons jjg at openjdk.java.net
Tue Oct 5 17:26:12 UTC 2021


On Tue, 5 Oct 2021 16:28:05 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

>> Joe Darcy has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Respond to review feedbakc.
>
> test/langtools/tools/javac/processing/ReportOnImportedModuleAnnotation/ReportOnImportedModuleAnnotation.java line 63:
> 
>> 61:         // Clean any existing class files in output directory
>> 62:         var tb = new ToolBox();
>> 63:         Files.walkFileTree(testOutputPath,
> 
> If it is OK to remove the entire directory contents, you could use `tb.cleanDirectory(testOutputPath);`

The code (here) to do a filtered delete suggests an RFE for `ToolBox`, for a new overload of `cleanDirectory` ;-)

-------------

PR: https://git.openjdk.java.net/jdk/pull/5802


More information about the compiler-dev mailing list