RFR: 8274244: ReportOnImportedModuleAnnotation.java fails on rerun [v4]
Joe Darcy
darcy at openjdk.java.net
Tue Oct 5 17:35:39 UTC 2021
> In terms of jtreg build tags, semantically this test wants to:
>
> * build annotation processing sources
> * compile module sources, running build annotation processor
>
> In particular, the test wants to always compile the module sources, even if class files are newer than the module-info.java files. Since the test is not written in terms of those tags, I've added a pre-step which delete any existing class files from the output directory. If needed, some extra care could be taken to only delete files from the one module.
>
> With this addition, the test will pass even when run with an already populated JTwork directory. At present, the test fails since the implicit compilation of module-info.java is *not* done when the class files in the output directory are newer than the sources.
Joe Darcy has updated the pull request incrementally with one additional commit since the last revision:
Clean up imports.
-------------
Changes:
- all: https://git.openjdk.java.net/jdk/pull/5802/files
- new: https://git.openjdk.java.net/jdk/pull/5802/files/1190616e..f09d43de
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jdk&pr=5802&range=03
- incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=5802&range=02-03
Stats: 4 lines in 1 file changed: 0 ins; 4 del; 0 mod
Patch: https://git.openjdk.java.net/jdk/pull/5802.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/5802/head:pull/5802
PR: https://git.openjdk.java.net/jdk/pull/5802
More information about the compiler-dev
mailing list