RFR: JDK-8273914: Indy string concat changes order of operations [v2]

[Aleksey Shipilev]

On Thu, 7 Oct 2021 19:44:10 GMT, Liam Miller-Cushon <cushon at openjdk.org> wrote:

>> This change makes string concatenation call `toString` on the arguments eagerly, to preserve the correct evaluation order of the arguments and the calls to `toString`.
>
> Liam Miller-Cushon has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Also test evaluation order for 'inline'
>  - Remove sharpestAccessible logic, since types are now passed as strings

test/langtools/tools/javac/StringConcat/StringAppendEvaluatesInOrder.java line 28:

> 26:  * @bug     8273914
> 27:  * @summary Indy string concat changes order of operations
> 28:  *

Here and later: please add the test block with `-XDstringConcat=inline` here as well, so that test would verify that every javac strategy produces the same result?

-------------

PR: https://git.openjdk.java.net/jdk/pull/5844