RFR: JDK-8273914: Indy string concat changes order of operations [v3]

[Liam Miller-Cushon]

> This change makes string concatenation call `toString` on the arguments eagerly, to preserve the correct evaluation order of the arguments and the calls to `toString`.

Liam Miller-Cushon has updated the pull request incrementally with one additional commit since the last revision:

  Document the rationale for the jasm changes

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/5844/files
  - new: https://git.openjdk.java.net/jdk/pull/5844/files/fabecf52..bd4cb71e

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=5844&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=5844&range=01-02

  Stats: 32 lines in 2 files changed: 32 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk/pull/5844.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/5844/head:pull/5844

PR: https://git.openjdk.java.net/jdk/pull/5844