RFR: 8274881: Update jdk.compiler classes to use try-with-resources

Joe Darcy darcy at openjdk.java.net
Tue Oct 12 02:55:48 UTC 2021


On Tue, 5 Oct 2021 07:52:40 GMT, Andrey Turbanov <duke at openjdk.java.net> wrote:

> 8274881: Update jdk.compiler classes to use try-with-resources

src/jdk.compiler/share/classes/com/sun/tools/javac/processing/ServiceProxy.java line 127:

> 125:             } catch (IOException y) {
> 126:                 fail(service, ": " + y);
> 127:             }

I haven't traced through this in detail, but it seems different exception behavior could occur.

src/jdk.compiler/share/classes/com/sun/tools/javac/util/ByteBuffer.java line 172:

> 170:                  * should be reported.
> 171:                  */
> 172:             }

The exception behavior seems like it could differ, which may or may not be an issue.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5816


More information about the compiler-dev mailing list