RFR: 8272234: Pass originating elements from Filer to JavaFileManager [v2]

Vicente Romero vromero at openjdk.java.net
Fri Oct 15 20:05:59 UTC 2021


On Fri, 15 Oct 2021 11:56:14 GMT, Jan Lahoda <jlahoda at openjdk.org> wrote:

>> This is a first prototype of a patch that propagates originating elements from `Filer` (`createSourceFile`/`createClassFile`/`createResource`) to the corresponding methods in `JavaFileManager`. As file managers generally don't know about `Element`s, the `Element`s are first converted to their corresponding `FileObject`s (if any). As the currently existing methods only take one `FileObject` as a sibling of the newly created file, a new set of methods is proposed that take multiple originating files.
>> 
>> Any feedback on this prototype would be welcome.
>
> Jan Lahoda has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 16 commits:
> 
>  - Javadoc improvements.
>  - Merge branch 'master' into ap-keep-originating-elements
>  - Cleanup.
>  - Improving testing
>  - Updating @since
>  - Merge branch 'master' into ap-keep-originating-elements
>  - Another attempt to fix the test.
>  - More attempts to fix the test.
>  - Attempting to fix test.
>  - Adding @since
>  - ... and 6 more: https://git.openjdk.java.net/jdk/compare/4cb7124c...9396bbb4

I guess this one needs a CSR right?

-------------

PR: https://git.openjdk.java.net/jdk/pull/5076


More information about the compiler-dev mailing list