RFR: JDK-8275308: Add valueOf(Runtime.Version) factory to SourceVersion [v2]

Joe Darcy darcy at openjdk.java.net
Sat Oct 16 00:02:09 UTC 2021


On Fri, 15 Oct 2021 23:32:35 GMT, Pavel Rappo <prappo at openjdk.org> wrote:

>> src/java.compiler/share/classes/javax/lang/model/SourceVersion.java line 515:
>> 
>>> 513:      * RELEASE_17}, is<br>:
>>> 514:      *
>>> 515:      * {@code SourceVersion.valueOf(Runtime.Version.parse(Integer.toString(17)))
>> 
>> Suggestion:
>> 
>>      * {@code SourceVersion.valueOf(Runtime.Version.parse(Integer.toString(17)))}
>
> I understand that this PR is an invitation to a discussion, not the final solution. Still, it's easier to reason about API whose doc comments render properly.

Doh! Sorry, fixed.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5973


More information about the compiler-dev mailing list