RFR: JDK-8273914: Indy string concat changes order of operations [v5]
Aleksey Shipilev
shade at openjdk.java.net
Mon Oct 18 06:47:51 UTC 2021
On Thu, 14 Oct 2021 17:14:42 GMT, Liam Miller-Cushon <cushon at openjdk.org> wrote:
>> This change makes string concatenation call `toString` on the arguments eagerly, to preserve the correct evaluation order of the arguments and the calls to `toString`.
>
> Liam Miller-Cushon has updated the pull request incrementally with one additional commit since the last revision:
>
> Rename WellKnownTypes to WellKnownTypeSignatures
>
> and add more functional test coverage for string concat of well-known
> types, covering all strategies.
Current change passes `tier{1,2,3,4}` for me. Still, I think compiler folks have to approve the javac change. @lahodaj, could you do it, or ask somebody else?
-------------
PR: https://git.openjdk.java.net/jdk/pull/5844
More information about the compiler-dev
mailing list