RFR: 8273314: Add tier4 test groups [v3]
Aleksey Shipilev
shade at openjdk.java.net
Fri Sep 17 06:59:10 UTC 2021
On Mon, 6 Sep 2021 13:22:03 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
>> During the review of JDK-8272914 that added hotspot:tier{2,3} groups, @iignatev suggested to create tier4 groups that capture all tests not in tiers{1,2,3}.
>>
>> Caveats:
>> - I excluded `applications` from `hotspot:tier4`, because they require test dependencies (e.g. jcstress).
>> - `jdk:tier4` only runs well with `JTREG_KEYWORDS=!headful` or reduced concurrency with `TEST_JOBS=1`, because headful tests cannot run in parallel
>>
>> Sample run with `JTREG_KEYWORDS=!headful`:
>>
>>
>> ==============================
>> Test summary
>> ==============================
>> TEST TOTAL PASS FAIL ERROR
>>>> jtreg:test/hotspot/jtreg:tier4 3585 3584 0 1 <<
>>>> jtreg:test/jdk:tier4 2893 2887 5 1 <<
>> jtreg:test/langtools:tier4 0 0 0 0
>> jtreg:test/jaxp:tier4 0 0 0 0
>> ==============================
>>
>> real 699m39.462s
>> user 6626m8.448s
>> sys 1110m43.704s
>>
>>
>> There are interesting test failures on my machine, which I would address separately.
>
> Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:
>
> Drop applications and fix the comment
All right, I am convinced that current patch is as good as it gets. GUI tests still do not run well with default parallelism, but I see no reason to block this integration before that is resolved. Either run `tier4` in headless mode, or limit the parallelism.
@iignatev, @mrserb, @dholmes-ora -- are you good with this?
-------------
PR: https://git.openjdk.java.net/jdk/pull/5357
More information about the compiler-dev
mailing list