RFR: JDK-8273244: Improve diagnostic output related to ErroneousTree [v2]

Jonathan Gibbons jjg at openjdk.java.net
Wed Sep 22 15:18:01 UTC 2021


On Wed, 22 Sep 2021 14:59:59 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

>> src/jdk.compiler/share/classes/com/sun/tools/javac/tree/DCTree.java line 265:
>> 
>>> 263:      * {@return a diagnostic position based on the positions in a comment}
>>> 264:      *
>>> 265:      * The positions are lazily converted to file-based positions as needed.
>> 
>> "lazily" somewhat duplicates "as needed", no?
>
> Noted

It doesn't read as well without "lazily" or "as needed".  Would prefer to mostly leave alone.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5510


More information about the compiler-dev mailing list