RFR: 8272358: Some tests may fail when executed with other locales than the US

Jie Fu jiefu at openjdk.java.net
Sat Sep 25 12:12:53 UTC 2021

On Sat, 25 Sep 2021 09:58:36 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

> > I still don't understand why the failures are different.
> The difference is that if the test uses golden data for EN locale only while the tested tool like javac supports more than one locale for some specific output message then the test should check that specific localized message.
> > But the fix doesn't work even with these 4 tests.
> Look like you use one of ja or zh_CN locales since only for these locales there are translations, the test should take it into account. It is not strictly correct to run add "-Duser.language=en -Duser.country=US" to it to fix such issues.

Thanks @mrserb for your clarification.

Shall we also fix ToolBasicTest.java and ToolSimpleTest.java just as what is done for LambdaTranslationTest1.java and LambdaTranslationTest2.java?
If so, the 4 tests would be also fixed on our MacOS platforms.

And do you test the fix on Linux?


PR: https://git.openjdk.java.net/jdk/pull/5098

More information about the compiler-dev mailing list