RFR: JDK-8273244: Improve diagnostic output related to ErroneousTree [v3]

Jonathan Gibbons jjg at openjdk.java.net
Wed Sep 29 03:07:43 UTC 2021


On Mon, 27 Sep 2021 15:49:25 GMT, Pavel Rappo <prappo at openjdk.org> wrote:

>> Jonathan Gibbons has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   address preliminary review comments
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/tree/DCTree.java line 177:
> 
>> 175:             }
>> 176: 
>> 177:             case AUTHOR, DEPRECATED, HIDDEN, PARAM, RETURN, SEE, SERIAL, SERIAL_DATA, SERIAL_FIELD, SINCE, THROWS, UNKNOWN_BLOCK_TAG, VERSION -> {
> 
> You added HIDDEN and merged PARAM into this case of block tags. Should we also add PROVIDES and USES? If so, then we should add respective tests.

Yes, and agreed.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5510


More information about the compiler-dev mailing list