RFR: 8284220: TypeMirror#toString omits enclosing class names after JDK-8281238 [v2]

Liam Miller-Cushon cushon at openjdk.java.net
Tue Apr 19 16:39:23 UTC 2022

On Mon, 4 Apr 2022 18:22:28 GMT, Joe Darcy <darcy at openjdk.org> wrote:

>> Liam Miller-Cushon has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
>>   8284220: TypeMirror#toString omits enclosing class names after JDK-8281238
> test/langtools/tools/javac/tree/NestedTypeToString.java line 24:
>> 22:  */
>> 23: 
>> 24: /*
> The fix for JDK-8281238 required several existing tests to be updated, so it did not have a dedicated test written for it. For this follow-on fix, if the test is going to use an annotation processor, which is quite reasonable, I suggest:
> * placing the test somewhere under test/langtools/tools/javac/processing/model
> *  subclassing JavacTestingAbstractProcessor
> *  using string-valued annotations to hold the expected result and checking them in the process method
> There are other tests using processor following this model under test/langtools/tools/javac/processing/model.

@jddarcy is there any other feedback I can address?


PR: https://git.openjdk.java.net/jdk/pull/8084

More information about the compiler-dev mailing list