RFR: JDK-8267690: Revisit (Doc)Tree search implemented by throwing an exception

Jonathan Gibbons jjg at openjdk.java.net
Mon Apr 25 18:41:16 UTC 2022

On Mon, 25 Apr 2022 16:21:35 GMT, Pavel Rappo <prappo at openjdk.org> wrote:

> I think I'm mistaken: your version does all these things I thought it wasn't doing. What's the difference between it and Jan's version? Is it more responsive wrt termination when the target node is found?

I didn't know/check Jan's version. If there's an equivalent version, I'm OK to share authorship credits, but not fussed either way.

> src/jdk.compiler/share/classes/com/sun/source/util/TreePath.java line 69:
>> 67: 
>> 68:             @Override
>> 69:             public TreePath scan(TreePath path, Tree docTree) {
> The second parameter has nothing to do with `DocTree`. Copy-paste?

good catch; thanks. copy-paste error; will fix


PR: https://git.openjdk.java.net/jdk/pull/8369

More information about the compiler-dev mailing list