RFR: JDK-8289249: Add methods to Elements for record constructors

Vicente Romero vromero at openjdk.org
Thu Aug 4 16:17:05 UTC 2022


On Sun, 31 Jul 2022 02:43:49 GMT, Joe Darcy <darcy at openjdk.org> wrote:

> Please review the addition of two predicates to better support records in the javax.lang.model API.
> 
> Please also review the CSR https://bugs.openjdk.org/browse/JDK-8291594

looks good to me

test/langtools/tools/javac/processing/model/util/elements/TestRecordPredicates.java line 110:

> 108:     }
> 109: 
> 110:     @ExpectedPredicates(isCompact=true, isCanonical=true)

side: this is uncovering a bug in the compiler, isCanonical should be false in this case. I have filed JDK-8291914 to address this issue

-------------

Marked as reviewed by vromero (Reviewer).

PR: https://git.openjdk.org/jdk/pull/9694


More information about the compiler-dev mailing list