RFR: 8297875: jar should not compress the manifest directory entry [v2]

Liam Miller-Cushon cushon at openjdk.org
Thu Dec 1 17:00:03 UTC 2022


On Thu, 1 Dec 2022 11:44:07 GMT, Lance Andersen <lancea at openjdk.org> wrote:

>> Unfortunately it's recursing on `cleanup` in the lambda, so it can't throw checked exceptions without more refactoring. This is imitating the recursive deletion approach in another jar test, I'm happy to swap this out if you'd prefer a different approach
>
> Thanks for the reminder regarding lambada/checked exceptions. I think this can be simplified to just write the jar and test file to the current directory and then just call
> 
> 
> Files.deleteIfExists(Path.of(JAR_FILE_NAME));
> Files.deleteIfExists(Path.of(FILE_NAME));
> 
> 
> as they are the only files used by the test .

Done, thanks

-------------

PR: https://git.openjdk.org/jdk/pull/11441


More information about the compiler-dev mailing list