RFR: 8295184: Printing messages with a RecordComponentElement does not include position

[Vicente Romero]

On Mon, 5 Dec 2022 11:57:36 GMT, Srikanth Adayapalam <sadayapalam at openjdk.org> wrote:

> Stash away a copy of the record component declaration from the header for use in diagnostics

just a minor suggestion, looks good

src/jdk.compiler/share/classes/com/sun/tools/javac/code/Symbol.java line 1797:

> 1795:         private final boolean isVarargs;
> 1796: 
> 1797:         public JCVariableDecl ast;

I wouldn't let this field, public we would like to at least control that nobody can accidentally overwrite this field, so my proposal is to make it private and let clients read it

-------------

Marked as reviewed by vromero (Reviewer).

PR: https://git.openjdk.org/jdk/pull/11511