RFR: 8200610: Compiling fails with java.nio.file.ReadOnlyFileSystemException [v3]

[Archie L. Cobbs]

On Thu, 8 Dec 2022 02:22:23 GMT, Archie L. Cobbs <duke at openjdk.org> wrote:

>> In `JavaCompiler`, when trying to write a class file, if an `IOException`s is thrown, instead of crashing, we report a normal error" `error while writing [file]: ...`.
>> 
>> However there are some I/O errors that can generate `RuntimeException`s not caught by this logic. So instead these errors cause a compiler crash.
>> 
>> An example is given in JDK-8200610, where the compiler tries to write into a ZIP file system and a `java.nio.file.ReadOnlyFileSystemException` is thrown.
>> 
>> This patch adds that exception and a couple of others which (in my estimation) could reasonably be expected to be thrown in various obscure cases involving alternative file systems: `FileSystemNotFoundException` and `InvalidPathException`.
>> 
>> Any suggestions on what the most appropriate list of exception types to include here are appreciated.
>
> Archie L. Cobbs has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
> 
>  - Merge branch 'master' into JDK-8200610
>  - Address review items (add UncheckedIOException and reformat).
>  - Merge branch 'master' into JDK-8200610
>  - Catch and report some java.nio.file.* exceptions along with IOException.

Thanks!

-------------

PR: https://git.openjdk.org/jdk/pull/10818