RFR: 8298943: Add missing escapes for single quotes in compiler.properties

Jonathan Gibbons jjg at openjdk.org
Fri Dec 16 21:17:49 UTC 2022


On Fri, 16 Dec 2022 15:11:18 GMT, Archie L. Cobbs <duke at openjdk.org> wrote:

> The source file `compiler.properties` contains the English message bundle for compiler warnings, errors, etc.
> 
> Since the strings in this file are format strings, any single quotes must be escaped by doubling them.
> 
> An example of a properly encoded entry is:
> 
> 
> compiler.err.cant.assign.val.to.this=\
>     cannot assign to ''this''
> 
> 
> There are three entries that appear to be not escaped when they should be.

Marked as reviewed by jjg (Reviewer).

@archiecobbs You need to fix the PR title.

An interesting followup might be to update the `CheckResourceKeys` test to proactively check for this error condition.

-------------

PR: https://git.openjdk.org/jdk/pull/11712


More information about the compiler-dev mailing list