RFR: 8298943: Missing escapes for single quote marks in compiler.properties [v4]

Archie L. Cobbs duke at openjdk.org
Mon Dec 19 15:44:25 UTC 2022


> The source file `compiler.properties` contains the English message bundle for compiler warnings, errors, etc.
> 
> Since the strings in this file are format strings, any single quotes must be escaped by doubling them.
> 
> An example of a properly encoded entry is:
> 
> 
> compiler.err.cant.assign.val.to.this=\
>     cannot assign to ''this''
> 
> 
> There are three entries that appear to be not escaped when they should be.

Archie L. Cobbs has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:

 - Merge branch 'master' into JDK-8298943
 - Allow quoting of ',' characters.
 - Add syntax checking of MessageFormat patterns in resouce bundles.
 - Add missing escapes for single quotes.

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/11712/files
  - new: https://git.openjdk.org/jdk/pull/11712/files/fe523617..ec386574

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=11712&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=11712&range=02-03

  Stats: 1859 lines in 73 files changed: 858 ins; 309 del; 692 mod
  Patch: https://git.openjdk.org/jdk/pull/11712.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/11712/head:pull/11712

PR: https://git.openjdk.org/jdk/pull/11712


More information about the compiler-dev mailing list