RFR: 8298943: Missing escapes for single quote marks in compiler.properties [v4]

Archie L. Cobbs duke at openjdk.org
Mon Dec 19 19:25:50 UTC 2022


On Mon, 19 Dec 2022 18:07:01 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

> At some point (not here and now in this review) we should maybe try and merge this with the copy-pasted version for javadoc, also called CheckResourceKeys.

Agreed... and to expand/digress even further, what would really be nice is for `MessageFormat` to make its double secret parsing algorithm (which supports arbitrarily many levels of nesting) available to the general public somehow. This would make it easier to develop tools related to format strings (see also [this class](https://github.com/archiecobbs/dellroad-stuff/blob/master/dellroad-stuff-main/src/main/java/org/dellroad/stuff/text/MessageFmt.java) which relies on introspection hacks).

Thanks for the review.

-------------

PR: https://git.openjdk.org/jdk/pull/11712


More information about the compiler-dev mailing list