RFE: Comment in javax.lang.model.Source version implies non-sealed should be a keyword

Vicente Romero vicente.romero at oracle.com
Wed Feb 2 16:41:18 UTC 2022


yep I think those lines could be removed,


On 2/2/22 00:04, Ethan McCue wrote:
> New here, so apologies If I am doing the procedure wrong.
> https://github.com/openjdk/jdk/blob/master/src/java.compiler/share/classes/javax/lang/model/SourceVersion.java#L465
> This comment implies that once sealed classes would be made a 
> non-preview feature that `non-sealed` should be added to this 
> predicate. I think the current behavior is correct since it's a 
> contextual keyword, but the comment should probably go.
> If I am right and that is the case, my understanding is that I need a 
> sponsor in order to make a PR to delete those lines. Is that correct?

More information about the compiler-dev mailing list