RFR: 8281507: Two javac tests have bad jtreg `@clean` tags [v2]

[Aleksey Shipilev]

On Wed, 9 Feb 2022 23:13:43 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

>> Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Use clean * instead
>
> test/langtools/tools/javac/8074306/TestSyntheticNullChecks.java line 30:
> 
>> 28:  * @compile -source 7 -target 7 TestSyntheticNullChecks.java
>> 29:  * @run main TestSyntheticNullChecks 7
>> 30:  * @clean TestSyntheticNullChecks
> 
> This test class has an inner class.  If the original intent was to try to remove all class files, the change is not equivalent, and will not do that; it will clean the main class, but not the nested class.
> 
> You may want to use `@clean *` instead, which will clean (remove) all class files in the default package.

Right, fixed.

> test/langtools/tools/javac/StringConcat/TestIndyStringConcat.java line 37:
> 
>> 35:  * @modules jdk.jdeps/com.sun.tools.classfile
>> 36:  *
>> 37:  * @clean TestIndyStringConcat
> 
> While this class does not appear to generate any nested classes, you may still want to use `@clean *` to ensure that any/all previously generated class files are removed.

Right, fixed.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7398