[jdk18] Integrated: JDK-8273452: DocTrees.getDocCommentTree should be specified as idempotent

Hannes Wallnöfer hannesw at openjdk.java.net
Mon Jan 10 12:07:29 UTC 2022


On Thu, 16 Dec 2021 11:05:01 GMT, Hannes Wallnöfer <hannesw at openjdk.org> wrote:

> Please review a doc-only change to add implementation notes to the `DocTrees.getDocCommentTree` methods, some of which return the same `DocCommentTree` instance on repeated invocation and some don't. I decided to use `@implNote` instead of `@implSpec` as usually I wouldn't expect object identity to be part of a Java API specification.
> 
> I verified the described behavior using code analysis and enhancing existing tests. The latter are not included in the commit as this is a `noreg-doc` issue.

This pull request has now been integrated.

Changeset: 354c9047
Author:    Hannes Wallnöfer <hannesw at openjdk.org>
URL:       https://git.openjdk.java.net/jdk18/commit/354c9047987c0837d95440780993a0aa84551ea1
Stats:     16 lines in 1 file changed: 16 ins; 0 del; 0 mod

8273452: DocTrees.getDocCommentTree should be specified as idempotent

Reviewed-by: jjg

-------------

PR: https://git.openjdk.java.net/jdk18/pull/36


More information about the compiler-dev mailing list